Skip to content

Add support for Aero 17 XE5#14

Open
mpolishchuck wants to merge 4 commits into
blmhemu:masterfrom
mpolishchuck:master
Open

Add support for Aero 17 XE5#14
mpolishchuck wants to merge 4 commits into
blmhemu:masterfrom
mpolishchuck:master

Conversation

@mpolishchuck

@mpolishchuck mpolishchuck commented Oct 7, 2023

Copy link
Copy Markdown

Hello.

Just wanted to add support for my laptop Aero 17 XE5.

Seems like everything what is implemented so for is working on this model too.

However, there are two things:

  1. Fn+F12 generates different code. I've added new constant for it.
  2. When Fn key is being pressed then keyboard generated Xf86TouchpadOff button event. I do no know if it happens on other models. If yes then this is out of scope. Otherwise this should be fixed here. Not sure what to do with this. (This is solved for Aero 17 XE5 explicitly, see my note in conversation about this PR)

@mpolishchuck

Copy link
Copy Markdown
Author

Updated PR to solve point 2 from my note above. However I'm still not sure if it happens on other models, so it will work only for Aero 17 XE5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant