Add RealToBinary golang binding#68
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a Go binding for the Faiss C API faiss_real_to_binary, enabling conversion of a batch of real-valued vectors (n*d float32 table) into packed binary vectors (LSB bit packing), which is useful for interacting with Faiss binary/vector-quantization workflows.
Changes:
- Add the missing Faiss C header include needed for the
faiss_real_to_binarysymbol. - Introduce
RealToBinary(x []float32, d int) []uint8helper to binarize vectors inton*(d/8)bytes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
capemox
approved these changes
Jun 2, 2026
Thejas-bhat
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
faiss_real_to_binaryAPI that binarizes a batch ofn * dinput vector table in LSB format.