feat(BbDateRangePicker): add two parameters : DisplayButtons and Auto…#244
feat(BbDateRangePicker): add two parameters : DisplayButtons and Auto…#244Yoannnn wants to merge 1 commit into
Conversation
|
Hi @Yoannnn, thanks for the contribution! Both That said, in its current shape the PR introduces too much noise into the repo for me to take it as-is. The actual feature is maybe 30 to 40 substantive lines, but it's currently buried in ~150 lines of unrelated formatting churn which makes it really hard to review and bloats the diff. Could you please rework it before we go further? Here's what needs addressing: 1. Heavy formatting/whitespace churnLooks like the IDE auto-reformatted large sections of Could you revert the formatting on lines you didn't intentionally change? The goal is for the diff to show only the new feature, not the whole file rewritten. 2. API surface snapshot test is failingThe ./scripts/run-tests.sh --acceptand commit the updated 3. Missing XML doc comments on the new parametersOther parameters in 4. Parameter declaration styleThe new parameters are declared on a single line: [Parameter] public bool DisplayButtons { get; set; } = true;
[Parameter] public bool AutoApply { get; set; } = false;Every other parameter in this class uses the multi-line form with the attribute on its own line. Please match the existing style. 5.
|
…Apply
Description
Add parameters to BbDateRangePicker :
Type of Change
Testing Checklist
Related Issues