Classify refresh token errors as expected authentication failures - #366
Draft
mendral-app[bot] wants to merge 1 commit into
Draft
Classify refresh token errors as expected authentication failures#366mendral-app[bot] wants to merge 1 commit into
mendral-app[bot] wants to merge 1 commit into
Conversation
OAuth2 refresh token failures from the SDK are untyped errors that fall through the CLI's error classifier and get incorrectly reported to Sentry as internal bugs. Add string-based detection for refresh token errors in classifyCLIError() and IsAuthError() so they are treated as expected authentication failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
classifyCLIError()so they are classified asCLIErrorAuthentication(expected) instead of falling through toCLIErrorInternaland being reported to SentryIsAuthError()to recognize refresh token failures, enabling the auth source hint to be displayed for these errorsFixes: https://app.mendral.com/insights/01KZA9YF2CD65M6NYV5KQM393D
Note
Created by Mendral. Tag @mendral-app with feedback or questions.