chore(deps): fix critical/high Dependabot alerts in toolkit - #363
Merged
Conversation
…igh Dependabot alerts Co-Authored-By: cploujoux <cploujoux@blaxel.ai>
cploujoux
self-requested a review
July 30, 2026 21:26
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
There was a problem hiding this comment.
LGTM
Pure dependency bump with no application code changes. The spf13/pflag indirect→direct correction is verified (directly imported in cli/core/sentry.go). The genproto monolith→split-module migration and protobuf bump are the expected companions for grpc ≥1.62. No concerns.
Tag @mendral-app with feedback or questions. View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes all 3 open critical/high Dependabot alerts in this repo: 3 alerts closed, 0 skipped, 0 blocked. Every alert is the same package —
google.golang.org/grpc, an indirect dependency pulled in only bygithub.com/google/goexpect(used bytest/integration/cli_create_tty_test.go). Nothing in the repo imports gRPC directly.Bumping grpc from
v1.31.0(pre-protobuf-APIv2 era) tov1.82.1forces two companion bumps, because grpc ≥ v1.62 requires APIv2protoreflect-capable generated code:google.golang.org/protobuf v1.31.0 → v1.36.11google.golang.org/genproto v0.0.0-2019… (monolith)→ split modulegoogle.golang.org/genproto/googleapis/rpc v0.0.0-20260729…The genproto split matters: with only the 2019 monolith in the build list,
grpc/internal/statusfailed to compile (*genproto/googleapis/rpc/status.Status does not implement protoreflect.ProtoMessage); adding the split module alone producedambiguous import. Both had to move, after whichgo mod tidydropped the monolith and the now-unusedgithub.com/golang/protobuf.spf13/pflaglost its// indirectmarker — it is genuinely direct (cli/core/sentry.go).Alerts fixed
go.mod< 1.79.3)grpc/codes+grpc/statusgo build ./...,go vet ./...,go test -count=1 ./...,make lintall passgo.mod< 1.82.1)go.mod< 1.56.3)Companion (non-alert) bumps required to compile:
google.golang.org/protobuf v1.31.0 → v1.36.11,google.golang.org/genproto/googleapis/rpcadded atv0.0.0-20260729162451-8efbd57d26e0,google.golang.org/genproto(monolith) andgithub.com/golang/protobufremoved.v1.82.1is the smallest version clearing all three advisories (max of the threefirst_patched_versionvalues: 1.56.3, 1.79.3, 1.82.1).Validation
v1.82.1 >= 1.82.1 > 1.79.3 > 1.56.3; outside everyvulnerable_version_range. ✅v1; no import-path change (/v2not involved), so no code edits needed. ✅gh api /repos/grpc/grpc-go/releases --paginate) and scanned the bodies of all 112 releases in the(v1.31.0, v1.82.1]range forBREAKING|API Change|Behavior Change|removed|deprecat|renamed|no longer|migration|minimum version. Relevant findings:v1.81.0: "Minimum supported Go version is now 1.25." — repogo.moddeclaresgo 1.25.11, CI usesgo-version: 1.25.xwithcheck-latest: true. ✅grpc.WithBalancerName(v1.46),grpc.WithServiceConfig(v1.60),resolver.ClientConn.NewServiceConfig(v1.60),resolver.Target.Endpointfield (v1.53),resolver.AddressType(v1.58),resolver.Target.Scheme/Authority(v1.57),Balancer.BuildOptions.MetricsRecorder(v1.71). None of these packages are imported anywhere in this repo or in goexpect.v1.62.0: proto library switch — "github.com/golang/protobufwould error if given anilmessage toMarshal" behavior change. Only reachable via proto marshalling, which this repo does not do.v1.82.0: strict incoming RPC path validation can no longer be disabled;v1.67.0: TLS connections without ALPN rejected. Both are server/client-transport behaviors — the repo runs no gRPC client or server.grep -rn "google.golang.org/grpc" --include=*.go .→ zero hits in repo code. The only consumer is goexpect, which imports exactlygoogle.golang.org/grpc/codesandgoogle.golang.org/grpc/status(expect.go:24-25) — both untouched by any removal above. The repo's single goexpect call site usesexpect.SpawnWithArgs(...)+expect.SetEnv(...), no gRPC surface at all.go build ./...✅ ;go vet ./...✅ (both clean;go mod tidyrun afterwards).go test -count=1 ./...(the exact command from.github/workflows/unit-tests.yamlandmake test): all unit packages ok.make lint(golangci-lint run): clean, no findings../test/integration/...fails, but identically on unmodifiedorigin/main— verified by running the same suite in a cleangit worktreeoforigin/main: same 7 failures (TestCreateCommands_TTYAndNoTTY,TestCLIWorkflow_*), caused bypermission denied for workspace "main"and missing--template/create-mcp-serverCLI surface. Pre-existing and unrelated to this bump; these need live platform credentials (.github/workflows/integration-tests.yaml).Not fixed
Nothing. All 3 open critical/high alerts are closed by this single bump. No alert lacked a patched version, no major bump was required, and no source-code changes were needed.
Notes for reviewers
Although semver-wise this is a minor bump, it spans 51 minor releases and drags protobuf runtime + genproto with it, so it is not being self-merged — gRPC/protobuf sit under a networking-adjacent dependency, so a human sign-off is requested even though the affected code path is confined to one integration test's process-spawning helper.
Link to Devin session: https://app.devin.ai/sessions/479cfb5d5091456295159c4f6c5c6608
Requested by: @cploujoux
Note
Bumps
google.golang.org/grpcfrom v1.31.0 to v1.82.1 to resolve 3 critical/high Dependabot alerts, along with required companion bumps togoogle.golang.org/protobufand the genproto split module. Removes the now-unusedgithub.com/golang/protobufand correctsspf13/pflagfrom indirect to direct.Written by Mendral for commit 90fa1f5.