Skip to content

Mark workspace errors as expected - #360

Merged
Joffref merged 1 commit into
mainfrom
mendral/mark-workspace-errors-expected
Jul 30, 2026
Merged

Mark workspace errors as expected#360
Joffref merged 1 commit into
mainfrom
mendral/mark-workspace-errors-expected

Conversation

@mendral-app

@mendral-app mendral-app Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Wrap workspace validation errors with core.MarkExpectedError(..., CLIErrorAuthentication) in apikey.go and client_credentials.go to prevent expected user-facing permission denials from being reported to Sentry as unhandled defects
  • Add test coverage for workspace permission denied error classification

Resolves insight: Workspace permission errors incorrectly reported to Sentry (CLI-33).


Note

Created by Mendral. Tag @mendral-app with feedback or questions.

@mendral-app
mendral-app Bot requested a review from a team July 29, 2026 23:22
Wrap workspace validation errors with MarkExpectedError(..., CLIErrorAuthentication)
in apikey.go and client_credentials.go to prevent expected user-facing permission
denials from being reported to Sentry as unhandled defects.
@Joffref
Joffref force-pushed the mendral/mark-workspace-errors-expected branch from b897e9a to 9b4f181 Compare July 30, 2026 01:41
@Joffref
Joffref deployed to integration-tests July 30, 2026 01:41 — with GitHub Actions Active
@Joffref
Joffref marked this pull request as ready for review July 30, 2026 01:42

@Joffref Joffref left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Joffref
Joffref merged commit 12b88d7 into main Jul 30, 2026
6 checks passed
@Joffref
Joffref deleted the mendral/mark-workspace-errors-expected branch July 30, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant