Mark workspace errors as expected - #360
Merged
Merged
Conversation
Joffref
had a problem deploying
to
integration-tests
July 30, 2026 01:41 — with
GitHub Actions
Error
Wrap workspace validation errors with MarkExpectedError(..., CLIErrorAuthentication) in apikey.go and client_credentials.go to prevent expected user-facing permission denials from being reported to Sentry as unhandled defects.
Joffref
force-pushed
the
mendral/mark-workspace-errors-expected
branch
from
July 30, 2026 01:41
b897e9a to
9b4f181
Compare
Joffref
marked this pull request as ready for review
July 30, 2026 01:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core.MarkExpectedError(..., CLIErrorAuthentication)inapikey.goandclient_credentials.goto prevent expected user-facing permission denials from being reported to Sentry as unhandled defectsResolves insight: Workspace permission errors incorrectly reported to Sentry (CLI-33).
Note
Created by Mendral. Tag @mendral-app with feedback or questions.