feat: DLC multi-select, PSP gameview, annotations, CI pipeline fixes,…#461
feat: DLC multi-select, PSP gameview, annotations, CI pipeline fixes,…#461toaster-code wants to merge 12 commits into
Conversation
… Linux simulator - DLC multi-select: select up to 32 DLCs before queueing (S button) - Annotation system: flag games with custom status (Favorite, Good, Bad, etc.) - PSP gameview: open game details for PSP games same as Vita games - PSM Runtime auto-download when installing a PSM game - Redownload prompt for already-installed games - Linux simulator: full SDL2-based desktop build for development/testing - CI: GitHub Actions pipeline for PS Vita VPK + Host Linux binaries - CI: fix missing openssl and zstd dependencies for curl (VitaSDK conan recipe) - CI: upgrade to ubuntu-24.04, Node.js 24, actions/checkout@v5
|
I was thinking maybe I've should made a fork from a commit did by Yoti (where I originally started my own fork), but due to some mess work of mine I've lost track of changes and sent a pull request here to blastrock. If I did this wrong I am open to fix. Thanks |
|
Hi, Well, thank you for your contribution! Unfortunately, I don't maintain this project anymore as I don't have the time for it, and the other maintainers too it seems, so there might be no one to review this PR. If I can give you some advice, the first one would be to split your commits, and even your PRs. No one can review efficiently 4000 lines of code, and that's for open source projects as well as anywhere in our industry. And my second advice would be to investigate if the project is still alive and if the maintainers are willing to review and integrate such work before starting it. This would avoid losing time with something the maintainers won't merge. In this specific case, you can wait a few days/weeks and see if the other maintainers would be willing to merge this. The other path forward would be for you to fork and maintain the project long term if you have the time and motivation for it. I don't think this is the response you expected, but I hope it helps :) |
|
Hi blastrock, First thanks for answering. Not at all. In fact your answer was the kind of feedback I was looking for. I agree with you (and I knew that I should to the way you proposed, but I was unsure). Sending small PR and try to let minor code changes being adopted is the best path. I done fork to fix cover art download, and then I got motivated to do more, and try other stuff. I think the next step now should be clean everything up, and to maintain properly I should keep small changes and send them to others that forked the repo. I could do mine by myself, but I would prefer to help due to my lack of experience (small steps first). Thank you again. I shall pull of the fork and then try what you proposed with some actual active maintainer and see. Best regards |
…nfig custom entries, and deploy helper
Implement a new category browser view for root navigation and integrate it into the main app state.
- Add BrowseView, BrowseNode and browser UI rendering in src/browserview.*
- Wire browse root state into src/pkgi.cpp and allow cancel/back to return to categories
- Replace multiple Show-mode menu entries with a single Back to categories action in src/menu.*
- Add custom entry parser/storage to config and save custom1..custom5 in src/config.{hpp,cpp}
- Add placeholder custom handler scaffolding in src/customhandler.* for future TSV-based install flows
- Add send_to_linux.sh to deploy latest ci/build{,test} .vpk or host pkgj_cli/pkgj_sim to a Linux target
- Fix PSP RIF string copy warning in src/pkgi.cpp using snprintf
- Fix psx read-size signed/unsigned comparisons in src/psx.cpp using SceSSize and explicit bounds checks
- Add browserview.cpp to cross and host build lists
Add Japanese font candidate discovery in simulator/sdl_backend.cpp and enable Japanese PGF support in src/vita.cpp for proper JPN text rendering.
Fix large RT/LT group overlay vertical alignment in Vita mode and adjust symbol group labeling for @ before A.
…cleanup, auto-update via GitHub releases
…ad PKGI_UPDATE_URL define
…merge - gameview: remove 'Scroll description' button; Description/Comment headers are now selectables at Panel level that enter SubItem (scroll) mode via X - gameview: add 2px inner padding to right panel (WindowPadding) - gameview: remove Title ID row from metadata - gameview: merge firmware rows into single line 'Required: X (current: Y)' - gameview: installed version + base compat pack shown on same line - gameview: increase label column width to 190px to prevent text truncation - gameview: remove redundant 'All green' diagnostic message - gameview: comment field now uses blue scrollable child window like description - gameview: add SubItemTarget enum (Description/Comment) for scroll focus - screenshotfetcher: rewrite to fetch chihiro container JSON first, extract actual screenshot URLs from images array (skipping cover = first image), then download images; thread-based approach like DescriptionFetcher - pkgi: merge Japanese font (jpn0.pvf) into Latin font atlas using MergeMode so Japanese characters render correctly in ImGui (GameView names/descriptions)
2 participants
I've made a cleaner pull request here :)
Main changes