Improve channel list refresh and live progress updates - #7
Open
miikasda wants to merge 3 commits into
Open
Conversation
Refresh the channel information when coming back e.g. from live tv otherwise old information is shown.
The "min(s) left" label and progress bar now refresh every minute instead of only when new programme information comes. The timer pauses off-screen via ChannelListDelegate, and catches up immediately whenever returning to the page e.g. from live tv.
Previously each page used channelsModel().active = visible. When Channels pushed Favorites as an attached (hidden) page, Favorites immediately fired that handler with visible === false, forcing the model inactive even though the Channels page was still showing. Now both pages toggle the flag in onStatusChanged, so only the currently active page controls the refresh timer and it reactivates properly when returned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More details in each commits commit message