🎨 Palette: Enhance accessibility of background music toggles#167
🎨 Palette: Enhance accessibility of background music toggles#167billlzzz10 wants to merge 1 commit into
Conversation
Added aria-pressed states and focus styles to the music toggle buttons, and hid decorative emojis from screen readers in the volume slider toggle. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
💡 What:
Added
aria-pressed={isPlaying}and keyboardfocus-visiblestates to the<MusicButton>and<MusicVolumeSlider>toggles insrc/components/kids/layout/background-music.tsx. Also wrapped the decorative volume emojis in<span aria-hidden="true">to prevent screen reader redundancy.🎯 Why:
Music buttons were lacking active state indication (
aria-pressed) for screen readers, meaning assistive technologies wouldn't announce whether the button was currently toggled on or off. They were also missing explicit keyboard focus styles for keyboard users. The decorative emojis within the volume text would be read aloud redundantly by screen readers.♿ Accessibility:
aria-pressedfor clear toggle state announcements.focus-visible:ring-2 focus-visible:outline-none focus-visible:ring-offset-2).aria-hidden="true".PR created automatically by Jules for task 1888140958068817616 started by @billlzzz10
Summary by cubic
Improve accessibility of the background music controls by adding aria-pressed to MusicButton and MusicVolumeSlider, adding focus-visible ring styles, and hiding decorative volume emojis from screen readers. Screen readers now announce on/off correctly, and keyboard users get clear focus indicators.
Written for commit db885e1. Summary will update on new commits.