🎨 Palette: Add accessibility attributes to layout buttons#165
🎨 Palette: Add accessibility attributes to layout buttons#165billlzzz10 wants to merge 3 commits into
Conversation
Added `type="button"` to layout buttons to prevent accidental form submission and explicitly set `aria-label` for better screen reader accessibility. Also added `aria-hidden="true"` to decorative icons inside the buttons. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Added `type="button"` to layout buttons to prevent accidental form submission and explicitly set `aria-label` for better screen reader accessibility. Also added `aria-hidden="true"` to decorative icons inside the buttons. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Added `type="button"` to layout buttons to prevent accidental form submission and explicitly set `aria-label` for better screen reader accessibility. Also added `aria-hidden="true"` to decorative icons inside the buttons. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
💡 What:
type="button"andaria-label={t("markAllRead")}to the "Mark all as read" button innotification-bell.tsx.type="button"andaria-label={tCommon("copy")}to the copy CLI command button incli-command.tsx.aria-hidden="true"to the decorativeTerminalicon incli-command.tsx.🎯 Why:
Buttons without explicit types can sometimes trigger unwanted form submissions if nested within a form context. Additionally, icon-only buttons or interactive elements require clear
aria-labels for screen reader users to understand their purpose, while decorative icons should be explicitly hidden from screen readers.📸 Before/After:
N/A - Purely structural/accessibility changes.
♿ Accessibility:
PR created automatically by Jules for task 13508517515729678888 started by @billlzzz10
Summary by cubic
Set
type="button"on layout buttons and addedaria-labels to improve screen reader support and prevent accidental form submissions. Applies to the notification bell’s “Mark all as read” and the CLI copy button; the decorativeTerminalicon isaria-hidden.Written for commit 991fd8b. Summary will update on new commits.