Skip to content

🎨 Palette: Add accessibility attributes to layout buttons#165

Draft
billlzzz10 wants to merge 3 commits into
mainfrom
palette/layout-buttons-a11y-13508517515729678888
Draft

🎨 Palette: Add accessibility attributes to layout buttons#165
billlzzz10 wants to merge 3 commits into
mainfrom
palette/layout-buttons-a11y-13508517515729678888

Conversation

@billlzzz10

@billlzzz10 billlzzz10 commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

💡 What:

  • Added type="button" and aria-label={t("markAllRead")} to the "Mark all as read" button in notification-bell.tsx.
  • Added type="button" and aria-label={tCommon("copy")} to the copy CLI command button in cli-command.tsx.
  • Added aria-hidden="true" to the decorative Terminal icon in cli-command.tsx.

🎯 Why:
Buttons without explicit types can sometimes trigger unwanted form submissions if nested within a form context. Additionally, icon-only buttons or interactive elements require clear aria-labels for screen reader users to understand their purpose, while decorative icons should be explicitly hidden from screen readers.

📸 Before/After:
N/A - Purely structural/accessibility changes.

♿ Accessibility:

  • Screen readers will now correctly announce "Mark all as read" and "Copy".
  • Decorative icons are properly hidden from assistive technologies.

PR created automatically by Jules for task 13508517515729678888 started by @billlzzz10


Summary by cubic

Set type="button" on layout buttons and added aria-labels to improve screen reader support and prevent accidental form submissions. Applies to the notification bell’s “Mark all as read” and the CLI copy button; the decorative Terminal icon is aria-hidden.

Written for commit 991fd8b. Summary will update on new commits.

Review in cubic

Added `type="button"` to layout buttons to prevent accidental form submission and explicitly set `aria-label` for better screen reader accessibility. Also added `aria-hidden="true"` to decorative icons inside the buttons.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agent-library Error Error Jul 18, 2026 6:57pm

@snyk-io

snyk-io Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2700f9a3-46f4-406b-8f8b-b0699ff3f01d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette/layout-buttons-a11y-13508517515729678888

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

billlzzz10 and others added 2 commits July 18, 2026 16:43
Added `type="button"` to layout buttons to prevent accidental form submission and explicitly set `aria-label` for better screen reader accessibility. Also added `aria-hidden="true"` to decorative icons inside the buttons.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Added `type="button"` to layout buttons to prevent accidental form submission and explicitly set `aria-label` for better screen reader accessibility. Also added `aria-hidden="true"` to decorative icons inside the buttons.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant