Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix XSS vulnerability in embed prompt#163

Draft
billlzzz10 wants to merge 2 commits into
mainfrom
sentinel/fix-xss-embed-18444249714437050523
Draft

πŸ›‘οΈ Sentinel: [CRITICAL] Fix XSS vulnerability in embed prompt#163
billlzzz10 wants to merge 2 commits into
mainfrom
sentinel/fix-xss-embed-18444249714437050523

Conversation

@billlzzz10

@billlzzz10 billlzzz10 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: The dangerouslySetInnerHTML React prop was being used to format dynamic text by converting mentions to HTML tags in the embed UI. User input was minimally escaped, leading to XSS if malicious scripts or mismatched tags were entered.
🎯 Impact: A malicious user could craft a prompt payload that would execute arbitrary JavaScript in the context of any user viewing the embed.
πŸ”§ Fix: Removed dangerouslySetInnerHTML completely. Instead, the highlightMentions function now parses the string into segments using a capturing regex (text.split(/(@\w+)/g)) and maps those segments into an array of React nodes (e.g., <span className="mention">...</span>). This leverages React's built-in, highly robust escaping for standard text nodes. Added finding to .jules/sentinel.md.
βœ… Verification: Ran pnpm test, pnpm lint, and pnpm format. All pass. Looked at the diff to ensure the fix correctly splits the mentions array.


PR created automatically by Jules for task 18444249714437050523 started by @billlzzz10


Summary by cubic

Fixes a critical XSS in the embed prompt by removing dangerouslySetInnerHTML and rendering mentions as React nodes. Prevents arbitrary script execution when viewing the embed.

  • Bug Fixes
    • Implemented highlightMentions that splits on (@\w+) and returns <span className="mention"> nodes.
    • Replaced the embed <p>’s dangerouslySetInnerHTML with safe React children.
    • Removed the custom escapeHtml utility and documented the fix in .jules/sentinel.md.

Written for commit 73eb1b9. Summary will update on new commits.

Review in cubic

Replaces dangerouslySetInnerHTML in the embed page with a safe
regex-based string splitting approach mapped directly to React nodes.
This ensures user input is properly escaped natively by React.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agent-library Error Error Jul 16, 2026 11:47pm

@snyk-io

snyk-io Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

βœ… Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
βœ… Open Source Security 0 0 0 0 0 issues

πŸ’» Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

βš™οΈ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 474d63f7-9277-4981-9118-d865619b1f74

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • πŸ” Trigger review
✨ Finishing Touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sentinel/fix-xss-embed-18444249714437050523

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

Replaces dangerouslySetInnerHTML in the embed page with a safe
regex-based string splitting approach mapped directly to React nodes.
This ensures user input is properly escaped natively by React.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant