π‘οΈ Sentinel: [CRITICAL] Fix XSS vulnerability in embed prompt#163
π‘οΈ Sentinel: [CRITICAL] Fix XSS vulnerability in embed prompt#163billlzzz10 wants to merge 2 commits into
Conversation
Replaces dangerouslySetInnerHTML in the embed page with a safe regex-based string splitting approach mapped directly to React nodes. This ensures user input is properly escaped natively by React. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
β Snyk checks have passed. No issues have been found so far.
π» Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the βοΈ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
β¨ Finishing Touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Replaces dangerouslySetInnerHTML in the embed page with a safe regex-based string splitting approach mapped directly to React nodes. This ensures user input is properly escaped natively by React. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
π¨ Severity: CRITICAL
π‘ Vulnerability: The
dangerouslySetInnerHTMLReact prop was being used to format dynamic text by converting mentions to HTML tags in the embed UI. User input was minimally escaped, leading to XSS if malicious scripts or mismatched tags were entered.π― Impact: A malicious user could craft a prompt payload that would execute arbitrary JavaScript in the context of any user viewing the embed.
π§ Fix: Removed
dangerouslySetInnerHTMLcompletely. Instead, thehighlightMentionsfunction now parses the string into segments using a capturing regex (text.split(/(@\w+)/g)) and maps those segments into an array of React nodes (e.g.,<span className="mention">...</span>). This leverages React's built-in, highly robust escaping for standard text nodes. Added finding to.jules/sentinel.md.β Verification: Ran
pnpm test,pnpm lint, andpnpm format. All pass. Looked at the diff to ensure the fix correctly splits the mentions array.PR created automatically by Jules for task 18444249714437050523 started by @billlzzz10
Summary by cubic
Fixes a critical XSS in the embed prompt by removing
dangerouslySetInnerHTMLand rendering mentions as React nodes. Prevents arbitrary script execution when viewing the embed.highlightMentionsthat splits on(@\w+)and returns<span className="mention">nodes.<p>βsdangerouslySetInnerHTMLwith safe React children.escapeHtmlutility and documented the fix in.jules/sentinel.md.Written for commit 73eb1b9. Summary will update on new commits.