🎨 Palette: Improve background music button accessibility#160
🎨 Palette: Improve background music button accessibility#160billlzzz10 wants to merge 2 commits into
Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
💡 What: Added
aria-pressed, explicitfocus-visiblestates, andaria-hiddenwrappers for emojis on background music toggle buttons.🎯 Why: To ensure screen readers accurately read out active/inactive states for the custom toggle buttons instead of redundantly announcing emojis, and to provide visible indicators for keyboard navigation.
📸 Before/After: Added styling and HTML attributes, visually identical unless using keyboard focus (where a brown ring now appears).
♿ Accessibility: Fully accessible custom toggles via ARIA attributes and focus-visible utilities.
PR created automatically by Jules for task 14160607016267089425 started by @billlzzz10
Summary by cubic
Improves accessibility of background music controls by announcing pressed state and showing a visible focus ring. Screen readers no longer read decorative emojis; keyboard users get clear focus feedback.
aria-pressedto music toggle buttons.focus-visiblering styles to custom buttons.<span aria-hidden="true">to prevent duplicate announcements.Written for commit ae320e0. Summary will update on new commits.