🎨 Palette: Add keyboard focus and ARIA pressed states to music controls#159
🎨 Palette: Add keyboard focus and ARIA pressed states to music controls#159billlzzz10 wants to merge 3 commits into
Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
💡 What:
aria-pressedattributes to the toggle buttons inMusicButtonandMusicVolumeSliderto properly communicate their on/off state to assistive technologies.focus-visible:utility classes to both toggle buttons.<span aria-hidden="true">in the volume slider to prevent redundant screen reader announcements.aria-label="Volume"to the<input type="range">in the volume slider..Jules/palette.mdregarding keyboard accessibility on custom-styled elements.🎯 Why:
To ensure the kids app settings and music controls are fully accessible to screen reader users and those navigating via keyboard.
📸 Before/After:
Before: Keyboard focus was invisible on the toggle buttons due to custom styling, and screen readers did not correctly announce their active state or the purpose of the volume slider.
After: The buttons now show a clear focus ring when navigated via keyboard. Screen readers will now announce "pressed" states appropriately, skip redundant emoji descriptions, and identify the range input as "Volume".
♿ Accessibility:
aria-pressedfor state management.focus-visible:ring-2,focus-visible:ring-offset-2).aria-hidden="true"on emojis).aria-label).PR created automatically by Jules for task 8298766276209503156 started by @billlzzz10
Summary by cubic
Improves accessibility of the kids app music controls by restoring keyboard focus styles and adding pressed state semantics. Screen readers now announce toggle state correctly, the volume slider is labeled, and decorative emojis are ignored.
aria-pressedtoMusicButtonand the volume toggle inMusicVolumeSlider.focus-visibleutilities to both buttons; documented the pattern in.Jules/palette.md.<span aria-hidden="true">to prevent redundant announcements.aria-label="Volume"to the range input.Written for commit f8bde35. Summary will update on new commits.