🎨 Palette: Add aria-hidden to decorative icons in buttons

[billlzzz10]

💡 What: Added aria-hidden="true" to decorative icons (like <XIcon>, <ChevronDown>, <Sparkles>) that sit inside buttons which already provide text for screen readers (either via an aria-label attribute on the button or an .sr-only span). Modified src/components/ui/dialog.tsx, src/components/ui/sheet.tsx, src/components/ui/json-tree-view.tsx, and src/components/ui/button.tsx.
🎯 Why: When a button is an icon-only button, screen readers will announce the button's aria-label or inner sr-only text. If the icon inside the button is not explicitly hidden from the accessibility tree, the screen reader might also try to read out the icon itself, resulting in redundant or confusing auditory feedback (e.g., "Close button, unlabelled graphic").
📸 Before/After: N/A - This is a purely structural change to the accessibility tree. Visually, the components look identical.
♿ Accessibility: Prevents redundant or confusing screen reader announcements by correctly hiding decorative icons in icon-only buttons that already have accessible names.

---

PR created automatically by Jules for task 17984090248834597311 started by @billlzzz10

---

Summary by cubic

Hide decorative SVG/Lucide icons in icon-only buttons by adding aria-hidden="true" when a label is present. Prevents double announcements; updates button, dialog, sheet, json-tree-view.

^{Written for commit 66fea48. Summary will update on new commits.}

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agent-library	Error		Jul 12, 2026 7:03pm

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0079ac92-ede3-43c6-959b-20399702e1d9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch palette-aria-hidden-icons-17984090248834597311

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[snyk-io]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.