🎨 Palette: Add ARIA labels and states to prompt writing guide buttons#146
🎨 Palette: Add ARIA labels and states to prompt writing guide buttons#146billlzzz10 wants to merge 5 commits into
Conversation
- Added `aria-label` to the icon-only "Copy" button. - Added `aria-expanded` to Section and PromptWritingGuide accordion toggle buttons. - Hid decorative icons (`BookOpen`, `ChevronUp`, `ChevronDown`, `Check`, `Copy`, and section icons) with `aria-hidden="true"`. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
- Added `aria-label` to the icon-only "Copy" button. - Added `aria-expanded` to Section and PromptWritingGuide accordion toggle buttons. - Hid decorative icons (`BookOpen`, `ChevronUp`, `ChevronDown`, `Check`, `Copy`, and section icons) with `aria-hidden="true"`. - Conditionally assign `DIRECT_URL` from `DATABASE_URL` in `prisma.config.ts` to satisfy CI Prisma validations without removing the default fallback. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
- Added `aria-label` to the icon-only "Copy" button. - Added `aria-expanded` to Section and PromptWritingGuide accordion toggle buttons. - Hid decorative icons (`BookOpen`, `ChevronUp`, `ChevronDown`, `Check`, `Copy`, and section icons) with `aria-hidden="true"`. - Conditionally assign `DIRECT_URL` from `DATABASE_URL` in `prisma.config.ts` to satisfy CI Prisma validations without removing the default fallback. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
- Added `aria-label` to the icon-only "Copy" button. - Added `aria-expanded` to Section and PromptWritingGuide accordion toggle buttons. - Hid decorative icons (`BookOpen`, `ChevronUp`, `ChevronDown`, `Check`, `Copy`, and section icons) with `aria-hidden="true"`. - Conditionally assign `DIRECT_URL` from `DATABASE_URL` in `prisma.config.ts` to satisfy CI Prisma validations while leaving the fallback intact with a TS ignore. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
- Added `aria-label` to the icon-only "Copy" button. - Added `aria-expanded` to Section and PromptWritingGuide accordion toggle buttons. - Hid decorative icons (`BookOpen`, `ChevronUp`, `ChevronDown`, `Check`, `Copy`, and section icons) with `aria-hidden="true"`. - Conditionally assign `DIRECT_URL` from `DATABASE_URL` in `prisma.config.ts` to satisfy CI Prisma validations while leaving the fallback intact. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
💡 What: Added missing ARIA accessibility attributes to the buttons and icons within
src/components/prompts/prompt-writing-guide.tsx.🎯 Why: To ensure that accordion and copy buttons communicate their state and function properly to screen readers without announcing redundant, decorative icon descriptions.
📸 Before/After: (No visual changes; purely DOM-level accessibility enhancements).
♿ Accessibility:
aria-label="Copy code"to the copy button.aria-expandedstate tracking to the accordion sections.aria-hidden="true"to decorative wrapper icons (Check,Copy,ChevronUp,ChevronDown,BookOpen, and standard section icons) to minimize screen reader noise.PR created automatically by Jules for task 10749751293668620914 started by @billlzzz10
Summary by cubic
Improves Prompt Writing Guide accessibility by adding ARIA labels/states and hiding decorative icons. Also fixes CI Prisma validation by setting
DIRECT_URLfromDATABASE_URLwhen missing; no visual changes.Accessibility
Check,Copy,BookOpen,ChevronUp,ChevronDown, and section icons)..Jules/palette.md.Bug Fixes
prisma.config.ts, assignDIRECT_URLfromDATABASE_URLwhen unset to satisfy Prisma validations in CI, keeping the default fallback.Written for commit bf5b1fc. Summary will update on new commits.