Skip to content

🎨 Palette: Improve accessibility in MCP server popup controls #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
billlzzz10 wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −4
Draft

🎨 Palette: Improve accessibility in MCP server popup controls #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/components/mcp/mcp-server-popup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export function McpServerPopup({
showOfficialBranding = false,
}: McpServerPopupProps) {
const t = useTranslations("mcp");
const tCommon = useTranslations("common");
const { data: session } = useSession();
const [isOpen, setIsOpen] = useState(false);
const [filtersOpen, setFiltersOpen] = useState(false);
Expand Down Expand Up @@ -148,6 +149,7 @@ export function McpServerPopup({
<div className="flex gap-0.5">
<button
onClick={() => setMcpMode("remote")}
aria-pressed={mcpMode === "remote"}
className={cn(
"rounded px-2 py-1 text-[11px] font-medium transition-colors",
mcpMode === "remote"
Expand All @@ -159,6 +161,7 @@ export function McpServerPopup({
</button>
<button
onClick={() => setMcpMode("local")}
aria-pressed={mcpMode === "local"}
className={cn(
"rounded px-2 py-1 text-[11px] font-medium transition-colors",
mcpMode === "local"
Expand Down Expand Up @@ -199,10 +202,12 @@ export function McpServerPopup({
<div className="border-t pt-2">
<button
onClick={() => setFiltersOpen(!filtersOpen)}
aria-expanded={filtersOpen}
className="text-muted-foreground hover:text-foreground flex w-full items-center justify-between text-[11px] transition-colors"
>
<span>{t("customizeFilters")}</span>
<ChevronDown
aria-hidden="true"
className={cn("h-3 w-3 transition-transform", filtersOpen && "rotate-180")}
/>
</button>
Expand Down Expand Up @@ -235,9 +240,10 @@ export function McpServerPopup({
@{user}
<button
onClick={() => removeUser(user)}
aria-label={`${tCommon("delete")} @${user}`}
className="hover:text-destructive"
>
<X className="h-2.5 w-2.5" />
<X aria-hidden="true" className="h-2.5 w-2.5" />
</button>
</Badge>
))}
Expand Down Expand Up @@ -276,9 +282,10 @@ export function McpServerPopup({
{cat}
<button
onClick={() => removeCategory(cat)}
aria-label={`${tCommon("delete")} ${cat}`}
className="hover:text-destructive"
>
<X className="h-2.5 w-2.5" />
<X aria-hidden="true" className="h-2.5 w-2.5" />
</button>
</Badge>
))}
Expand Down Expand Up @@ -310,8 +317,12 @@ export function McpServerPopup({
className="h-5 gap-0.5 pr-0.5 text-[10px]"
>
{tag}
<button onClick={() => removeTag(tag)} className="hover:text-destructive">
<X className="h-2.5 w-2.5" />
<button
onClick={() => removeTag(tag)}
aria-label={`${tCommon("delete")} ${tag}`}
className="hover:text-destructive"
>
<X aria-hidden="true" className="h-2.5 w-2.5" />
</button>
</Badge>
))}
Expand Down
Loading