Skip to content

AMD compatibility & manual initialization#15

Open
peschee wants to merge 6 commits into
bjork24:masterfrom
peschee:amd
Open

AMD compatibility & manual initialization#15
peschee wants to merge 6 commits into
bjork24:masterfrom
peschee:amd

Conversation

@peschee
Copy link
Copy Markdown
Contributor

@peschee peschee commented Jul 2, 2014

Hi

I have added some changes in my custom branch to support AMD loaders and to be able to initialize Unison "manually". The problem with the original implementation was, that if included it inside your own DOMContentLoaded listener, the event inside Unison never fires (since it fires once). I added the public util.initializeUnison method which can be called manually and initializes Unison.

Also, I added an .editorconfig file to support your syntax and made some format changes. Feel free to include this in your version.

P.S. Unison should still be exposed to the global namespace, so I assume that your comments plugin still works. However, I wasn't able to test this. Also, I have not added a minified version since I wasn't sure which minifier you usually use for your releases.

@peschee
Copy link
Copy Markdown
Contributor Author

peschee commented Sep 10, 2014

Any update on this? Can you please take a look @bjork24?

@weotch
Copy link
Copy Markdown

weotch commented Dec 12, 2014

Btw, this pull request made the difference for me. I ended up doing to fire stuff on load:

Unison.util.initializeUnison();
// ... add event listeners
Unison.emit(Unison.fetch.now().name); 

@peschee
Copy link
Copy Markdown
Contributor Author

peschee commented Dec 12, 2014

It seems as if @bjork24 is not really maintaining this anymore. But I guess we can live with forks.

weotch and others added 2 commits January 7, 2015 14:24
Comment thread .gitignore
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since .DS_Store is an environmental file, rather than a project file, you might want to add that into your global gitignore config instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants