Fix node-gyp-build interop for CJS importers in ESM output#4
Open
vweevers wants to merge 3 commits into
Open
Conversation
Assisted-by: gpt-5.5
Assisted-by: gpt-5.5
Assisted-by: gpt-5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scenario: I'm consuming a native addon from a CommonJS npm package, in an ESM bundle. Problem: the
vite-plugin-native-modulesplugin rewroterequire('node-gyp-build')(__dirname)to arequire()that points at the plugin's ESM virtual native wrapper. That made the CJS package receive the namespace object instead of the native addon itself.To make
vite-plugin-native-moduleswork in that scenario, I had to change the addon's entry point from:To:
This PR fixes it in the plugin. What I changed:
src/index.ts, CJS native-loader rewrites now emit.defaultwhen the final output format is ESM.test/node-gyp-build.test.ts.\paths for additionalNativeFiles (a6ed11c)win32is valid (21d25af).