Stricter data protection errors

[justindbaur]

🎟️ Tracking

📔 Objective

Add stricter and early exception when there are issues with getting certificates used in data protection. Before the CoreHelpers method we used would just completely swallow load errors and return null. The null in the case of protection certificates would result in a ArgumentNullException and null in the unprotect case would cause a delayed NullReferenceException when the first piece of data is unprotected.

This also removes the use of async over sync.

📸 Screenshots

[codecov]

Codecov Report

❌ Patch coverage is 76.92308% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.19%. Comparing base (408002d) to head (c06c246).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...ities/DataProtectionServiceCollectionExtensions.cs	76.92%	11 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7837      +/-   ##
==========================================
- Coverage   61.23%   61.19%   -0.04%     
==========================================
  Files        2209     2210       +1     
  Lines       97743    97754      +11     
  Branches     8815     8815              
==========================================
- Hits        59849    59819      -30     
- Misses      35770    35810      +40     
- Partials     2124     2125       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud