Update Commit Signing Doc#806
Draft
vgrassia wants to merge 2 commits into
Draft
Conversation
# Conflicts: # docs/contributing/commit-signing.mdx
Deploying contributing-docs with
|
| Latest commit: |
6d6383a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0da7aa26.contributing-docs.pages.dev |
| Branch Preview URL: | https://vgrassia-dev.contributing-docs.pages.dev |
quexten
requested changes
Jun 15, 2026
| 1. **[Hardware-backed SSH key](#hardware-backed-ssh-key)**: private key lives on a FIDO2 security | ||
| key (e.g., YubiKey 5+). Each commit requires a PIN and a physical touch. This is the most secure | ||
| option. | ||
| 2. **[Standard SSH key](#standard-ssh-key)**: private key lives on disk, protected by a passphrase. |
Contributor
There was a problem hiding this comment.
Why are we recommending on-disk SSH keys over bitwarden ssh agent? On most systems, the standard SSH key has fewer protections (no memory-dump protection, possibly no passphrase, and also no access control), wheras the Bitwarden-stored SSH agent has all three (assuming you did not configure to never ask for approval)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
📸 Screenshots