Fix --ignore flag not suppressing --erase targets#119
Merged
Conversation
Agent-Logs-Url: https://github.com/bittner/pyclean/sessions/3ed23a61-cc64-49a2-ae9f-50c4b6b3b529 Co-authored-by: bittner <665072+bittner@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix ignore flag to override erase flag targets
Fix --ignore flag not suppressing --erase targets
Mar 30, 2026
bittner
reviewed
Mar 30, 2026
Agent-Logs-Url: https://github.com/bittner/pyclean/sessions/50532ba3-817f-47df-a8fa-c01c1c8f78e3 Co-authored-by: bittner <665072+bittner@users.noreply.github.com>
bittner
reviewed
Mar 30, 2026
bittner
requested changes
Mar 30, 2026
bittner
left a comment
bittner
left a comment
Owner
There was a problem hiding this comment.
Make sure linting, formatting and tests pass.
…-function call in erase.py Agent-Logs-Url: https://github.com/bittner/pyclean/sessions/6eb036ae-d200-4616-bb20-7d471ee1178c Co-authored-by: bittner <665072+bittner@users.noreply.github.com>
…ormat issues Agent-Logs-Url: https://github.com/bittner/pyclean/sessions/47d57474-ae0e-4870-acae-97947226a21e Co-authored-by: bittner <665072+bittner@users.noreply.github.com>
Contributor
Author
Fixed in 8f54073. Lint, format, and all 100 tests pass. The lazy import that was causing |
bittner
approved these changes
Mar 30, 2026
bittner
added a commit
that referenced
this pull request
May 23, 2026
- Default `remove_freeform_targets`'s `explicit_ignore_patterns` to `[]` internally so production callers (`main.py`) and tests both exercise the same path. The `None`-fallback in `delete_filesystem_objects` remains for direct debris call sites only. - Update the #119 regression test to pass `explicit_ignore_patterns=['foo']` so it exercises the production wiring instead of the `Runner.ignore` fallback. - Add a regression test for case 3 of issue #122's precedence table — `pyclean DIR --erase '**/*' --ignore DIR` is a no-op. - Trim the hardcoded default ignore list to the patterns that actually matter in the two new erase tests (`.tox`, `keep.txt`). - Document the erase/ignore interaction in `remove_freeform_targets`'s docstring and in the README `--erase` section. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--ignorehad no effect on paths targeted by--erase: glob results were processed for deletion without consultingRunner.ignore, so ignored directories were deleted anyway.Changes
pyclean/erase.py: Added_path_is_ignored(path, ignore_patterns)that checks a path and all its ancestors against ignore patterns (delegating to the existingshould_ignorefromtraversal.py). Applied this filter to glob results indelete_filesystem_objectsbefore any deletion occurs.Example