Added feedback to create variables - #82
Open
Nico96R wants to merge 3 commits into
Open
Conversation
added 3 commits
May 17, 2026 11:44
update @companion-module/base to 2.0.4 and @companion-module/tools to ^3.0.1 migrate entrypoint and variable definitions for base 2.x, and align option expressions with new API
Julusian
reviewed
May 17, 2026
| }, | ||
| }, | ||
| osc_feedback_value: { | ||
| type: 'boolean', |
Julusian
reviewed
May 17, 2026
| this.log('debug', `Evaluating feedback ${feedback.id}.`); | ||
|
|
||
| const rx_args = this.onDataReceived[path]; | ||
| return String(rx_args[0].value); |
Member
There was a problem hiding this comment.
Probably shouldn't be blindly stringifying the value here; any json safe value is allowed. It would be good to preserve numbers.
Maybe this should check the arg type and stringify only for this which arent allowed? (some buffer/blob types probably)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added another feedback so you can use osc feedbacks as variables
Updated version number to 2.9.0