Skip to content

Backport of #2182: full_scan covers revealed range before applying stop_gap#2222

Open
thunderbiscuit wants to merge 2 commits into
bitcoindevkit:release/chain-0.23.xfrom
thunderbiscuit:release/chain-0.23.x
Open

Backport of #2182: full_scan covers revealed range before applying stop_gap#2222
thunderbiscuit wants to merge 2 commits into
bitcoindevkit:release/chain-0.23.xfrom
thunderbiscuit:release/chain-0.23.x

Conversation

@thunderbiscuit
Copy link
Copy Markdown
Member

This is a backport of the fix brought into #2182, allowing it to be released in the bdk_chain 0.23.x series so that users of bdk_wallet 3.0 can benefit from the bug fix.

See PR #2182 and issue #2057 for full discussion on the bug and the fix.

Changelog notice

## Fixed
- full_scan now always scans the full revealed range before applying stop_gap past last_revealed

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants