Allow post-deployment connections straight from graph files#814
Closed
sr-gi wants to merge 1 commit into
Closed
Conversation
sr-gi
force-pushed
the
2026-07-post-deploy-connections
branch
from
219761d to
1c202d6
Compare
Allows creating connections from a graph file other than manual. This connections are created after deployment using the addconnection (test-only) RPC. Connections are stored under a new tag in the graph files: addconnection. If any of this tags is found, the scenario is run right after deployment to create those connections. Otherwise, this is a noop. Graph file entry example: nodes: - addnode: - tank-0015 - tank-0013 - tank-0005 - tank-0006 - tank-0019 - tank-0014 - tank-0004 - tank-0021 addconnection: - tank-0010 - tank-0020
sr-gi
force-pushed
the
2026-07-post-deploy-connections
branch
from
1c202d6 to
d841d64
Compare
Contributor
|
This is cool, it's a feature I want, but I'm starting my own branch here: #815 The syntax in network.yaml might end up being slightly different |
Member
Author
|
SGTM, happy to adapt to the format you decide on downstream when merged. I'm currently running my patch downstream, but I'm also happy to ditch that one and run yours so I can give some practical review feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows creating connections from a graph file other than manual. This connections are created after deployment using the addconnection (test-only) RPC.
Connections are stored under a new tag in the graph files: addconnection. If any of this tags is found, the scenario is run right after deployment to create those connections. Otherwise, this is a noop.
Graph file entry example:
Disclaimer: addconnection.py has been highly vibecoded. Happy to trim it down or re-work it.