charts: be way more flexible about semver in tags#812
Merged
Conversation
Helm semverCompare does not match pre-release versions with >=
constraints. When the image tag is a pre-release like 31.1rc1, the
semver "31.1.0-rc.1" fails the ">=0.17.0" check, causing the [regtest]
section header to be omitted from bitcoin.conf.
Without the [regtest] header, Bitcoin Core >=0.17.0 rejects
network-specific options (addnode, rpcbind, rpcport) in the global
section, producing errors like:
Error: Invalid setting for -regtest.rpcbind: 0.0.0.0
Error: Invalid setting for -regtest.rpcport: 18444
Error: Invalid setting for -regtest.addnode: tank-0001
This causes pods to enter Error state and prevents the warnet from
deploying successfully.
Fix: strip the pre-release suffix (e.g. "-rc.1") from the semver
string before passing it to semverCompare, so "31.1.0" correctly
matches ">=0.17.0" and the [regtest] header is emitted.
Tested: deployed a 12-node warnet with image.tag: 31.1rc1 — all tanks
reached Running 2/2 with correct [regtest] config sections.
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The graph test is failing ci since I added 31.1rc1 to our supported tags in 0233dbc
This is not a new problem, we have a semver check so we don't create an invalid config file for old images. Problem is, the check is too strict and our tags are not always valid semver.
This patch uses LLM generated regex to make more tag variations valid semver.