BIP458: Schnorr (Incremental) Half Aggregation#1566
Open
fjahr wants to merge 4 commits into
Open
Conversation
jjones3695
approved these changes
Jul 16, 2024
fjahr
force-pushed
the
2024-07-half-agg
branch
2 times, most recently
from
6218bda to
0effa49
Compare
Contributor
Author
|
Rebased on the musig changes and added the compile options for cmake |
fjahr
force-pushed
the
2024-07-half-agg
branch
4 times, most recently
from
31c6b5d to
db91a39
Compare
fjahr
force-pushed
the
2024-07-half-agg
branch
from
db91a39 to
bcd6b9c
Compare
fjahr
force-pushed
the
2024-07-half-agg
branch
from
bcd6b9c to
19da8a9
Compare
Contributor
Author
|
Rebased to take into account the latest changes to cmake, CI and test framework. Also squashed the commit since maintaining them was annoying and there wasn't really a good reason for them. It was more of a crutch for me while I was taking my first steps here. |
fjahr
force-pushed
the
2024-07-half-agg
branch
from
19da8a9 to
ccc826d
Compare
6 tasks
fjahr
force-pushed
the
2024-07-half-agg
branch
2 times, most recently
from
d0ba26a to
653d368
Compare
Contributor
Author
|
Rebased and added the test vectors from the BIP draft: bitcoin/bips#2205 |
fjahr
changed the title
Code is based on the secp256k1-zkp implementation. Test vectors based on BIP 458: https://github.com/bitcoin/bips/blob/master/bip-0458.mediawiki Co-authored-by: Benedikt <crypto@benedikt-wagner.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements BIP458: bitcoin/bips#2205
The original version of this code ported over the work from b-wagn in BlockstreamResearch/secp256k1-zkp#261