Skip to content

fixed decryption not working in the browser for messages > 15#64

Merged
JBaczuk merged 7 commits into
bitchan:masterfrom
YZhenY:master
Aug 5, 2020
Merged

fixed decryption not working in the browser for messages > 15#64
JBaczuk merged 7 commits into
bitchan:masterfrom
YZhenY:master

Conversation

@YZhenY

@YZhenY YZhenY commented Jun 25, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@YZhenY YZhenY changed the title decryption not working in the browser for messages > 15 fixed decryption not working in the browser for messages > 15 Jun 25, 2020
@YZhenY

YZhenY commented Jun 25, 2020

Copy link
Copy Markdown
Contributor Author

ah did not realize #47

can we merge one or the other please @JBaczuk

@ibudisteanu

Copy link
Copy Markdown

@YZhenY great stuff. I believe your update is solving this issue created by me #67 isn't it ?

Comment thread README.md Outdated

@JBaczuk JBaczuk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, sorry for the late response. I noticed a few things that would need to be fixed before merging. Could you take a look?

Comment thread package.json
Comment thread test.js Outdated
Comment thread test.js
@YZhenY

YZhenY commented Jul 28, 2020

Copy link
Copy Markdown
Contributor Author

done! @JBaczuk @ibudisteanu

@YZhenY YZhenY requested a review from JBaczuk August 5, 2020 06:00
@JBaczuk JBaczuk merged commit bd98514 into bitchan:master Aug 5, 2020
@JBaczuk

JBaczuk commented Aug 5, 2020

Copy link
Copy Markdown
Contributor

Thanks @YZhenY !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants