Show target temp on temp bars#1691
Open
mutatrum wants to merge 1 commit into
Open
Conversation
0xf0xx0
requested changes
May 17, 2026
| info.hostname, | ||
| (info.hashRate ? HashSuffixPipe.transform(info.hashRate) : ''), | ||
| (info.temp ? `${info.temp}${info.temp2 > -1 ? `/${info.temp2}` : ''}${info.vrTemp ? `/${info.vrTemp}` : ''} °C` : ''), | ||
| (info.temp ? `${info.temp}${info.temp2 > -1 ? `/${info.temp2}` : ''}${info.vrTemp ? `/${info.vrTemp}` : ''} °C` : ''), |
Collaborator
There was a problem hiding this comment.
revert, borked
til html escape codes dont work in js
Collaborator
Author
There was a problem hiding this comment.
Ugh, noticed that as well. Will fix.
| case eChartLabel.asicTemp: | ||
| case eChartLabel.asicTemp2: | ||
| case eChartLabel.vrTemp: return {suffix: ' °C', precision: 1}; | ||
| case eChartLabel.vrTemp: return {suffix: ' °C', precision: 1}; |
| </p-progressBar> | ||
|
|
||
| <!-- Target temperature marker --> | ||
| <div *ngIf="info.autofanspeed === 1" class="absolute bg-white h-full top-0" |
Collaborator
There was a problem hiding this comment.
mayb make the tick the opposite of the bar bg? same with the voltage tick tbh
theres also a weird font issue but idk if its a me problem or not
Collaborator
There was a problem hiding this comment.
I think either is clean a white line is just bad if the target temp is beyond the color in that case we should choose the opposit. That could be handled in there or we choos a fixed color that's not on the color palett
| <!-- Target temperature marker --> | ||
| <div *ngIf="info.autofanspeed === 1" class="absolute bg-white h-full top-0" | ||
| [style.left]="(info.temptarget / maxTemp) * 100 + '%'" | ||
| style="width: 3px;"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show auto fan control target temperature:
Doesn't show when fan is on manual.