Upgrade AxeOS to Angular 19#1651
Open
mutatrum wants to merge 24 commits into
Open
Conversation
…angular-19 # Conflicts: # main/http_server/axe-os/src/app/components/home/home.component.html # main/http_server/axe-os/src/app/components/pool/pool.component.html
Collaborator
|
heck of a PR, will start the review this weekend |
Collaborator
Author
It's smaller than it looks, see comment above. It just deletes a gazillion files and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experimental migration to Angular 19. One of the biggest changes is that it's based off a default theme, instead of a copy-drop into the project. Not all elements are styled the same, so it needs polish, but this is mainly a feasibility exercise, and probably needs to be done again after #1622 and maybe other pending PRs.
The line count of this PR is massive, however, if you break it down:
package-lock.json: +8958/-7,850Rationale was that Angular 18 is no longer supported and the increasing number of security issues in the npm build part, which for a large part were coming from the Angular 18 dependencies:
Before:
60 vulnerabilities (9 low, 11 moderate, 39 high, 1 critical)After:
8 vulnerabilities (1 moderate, 7 high)Following this, the next step would be to migrate from PrimeFlex to Tailwind. But that can be done gradually.
Prior art: #885
It would be prudent to move forward to Angular 20 or latest, as Angular 19 is also almost EOL.