nl_l3: also compare prefix length in duplicate route check#490
Open
KanjiMonster wants to merge 1 commit into
Open
nl_l3: also compare prefix length in duplicate route check#490KanjiMonster wants to merge 1 commit into
KanjiMonster wants to merge 1 commit into
Conversation
When checking for duplicate routes, we also need to check the prefix lengths, else e.g. a route 10.0.0.0/8 will match with a 10.0.10.0/24 route. This can lead to routes falsely being identified as duplicates and not added or removed as expected. So switch from nl_addr_cmp_prefix() to nl_addr_cmp() to ensure that different prefix lengths will be treated as different routes. Fixes: 96e14a8 ("nl_l3: ignore duplicated link routes from FRR") Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking for duplicate routes, we also need to check the prefix lengths, else e.g. a route
10.0.0.0/8will match with a10.0.10.0/24route. This can lead to routes falsely being identified as duplicates and not added or removed as expected.So switch from
nl_addr_cmp_prefix()tonl_addr_cmp()to ensure that different prefix lengths will be treated as different routes.Fixes: 96e14a8 ("nl_l3: ignore duplicated link routes from FRR")