Skip to content

nl_bridge: do not try to flush fdb on removed interfaces #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubensfig merged 1 commit into from
Mar 4, 2026
Merged

nl_bridge: do not try to flush fdb on removed interfaces #487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/netlink/nl_bridge.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,14 +568,18 @@ void nl_bridge::update_vlans(rtnl_link *old_link, rtnl_link *new_link) {
// the PVID is already being handled outside of the loop
vlan->remove_bridge_vlan(_link, vid, false, !egress_untagged);

// remove all fdb entries by us
nl_fdb_flush ff;

auto ret = ff.flush_fdb(rtnl_link_get_ifindex(_link), vid,
NTF_MASTER | NTF_EXT_LEARNED);
if (ret < 0)
LOG(WARNING) << __FUNCTION__ << ": failed to flush vid=" << vid
<< " on port " << _link;
// only flush on updating interfaces, kernel will take of it when
// removing from the bridge (new_link is a nullptr)
if (new_link) {
// remove all fdb entries by us
Comment thread
rubensfig marked this conversation as resolved.
nl_fdb_flush ff;

auto ret = ff.flush_fdb(rtnl_link_get_ifindex(_link), vid,
NTF_MASTER | NTF_EXT_LEARNED);
if (ret < 0)
LOG(WARNING) << __FUNCTION__ << ": failed to flush vid=" << vid
<< " on port " << _link;
}
}
}
}
Expand Down