Skip to content

use mia when sampling NAs#54

Open
jkapar wants to merge 2 commits into
mainfrom
rarf_sample_NAs
Open

use mia when sampling NAs#54
jkapar wants to merge 2 commits into
mainfrom
rarf_sample_NAs

Conversation

@jkapar

@jkapar jkapar commented Apr 2, 2025

Copy link
Copy Markdown
Collaborator

Fit arf with mia = TRUE if rarf is called with sample_NAs = TRUE.

@jkapar
jkapar requested a review from mnwright April 2, 2025 22:36
@jkapar

jkapar commented Apr 2, 2025

Copy link
Copy Markdown
Collaborator Author

A ranger version check could be added to avoid the warning with older version without mia argument

@jemus42

jemus42 commented Jul 5, 2026

Copy link
Copy Markdown
Member

I'd consider this blocked by imbs-hl/ranger#761

I don't want to add functionality here that depends on an unmerged PR in an upstream dependency, even if a guard like "mia" %in% formals(ranger) would be version-agnostic and robust.

Also from what I see when the mia bit is merged in ranger we should probably promote this to a first-class argument in adversarial_rf as well, so users have the chance of discovering this is an option, currently this is just for convenience to make rarf pass the argument to ranger.

Soooo uh yeah idunno @mnwright has to decide what to do with the upstream ranger PR I guess 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants