Potential fix for code scanning alert no. 3: Uncontrolled data used in path expression#24
Merged
Conversation
…n path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ed in path expression' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ed in path expression' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Command-IDE/cmd-ide/security/code-scanning/3
The safest fix without changing intended preview functionality is to enforce a base directory constraint in
previewFileHandler:filepath.Abs+filepath.Clean.http.ServeFileonly after this check.For this file, the most practical base directory available from shown code is the current working directory (
os.Getwd()), which preserves expected “preview project files” behavior while preventing arbitrary filesystem reads.Changes required in
app/preview_server.go:osandstrings.previewFileHandler, replace the currentfilepath.IsAbs-only validation block with canonicalization + containment check (strings.HasPrefixwith path-separator-safe prefix logic).Suggested fixes powered by Copilot Autofix. Review carefully before merging.