refactor: split monolithic app.js into focused ES modules#38
Open
bin101 wants to merge 1 commit into
Open
Conversation
The 1450-line app.js is replaced by 12 focused ES modules: state.js, dom.js, api.js, format.js, schedule-matrix.js, athletes.js, config.js, settings.js, feed.js, status.js, tabs.js, main.js. The importmap in routes.py::serve_index now covers all local modules so every module is cache-busted on release. Entry point changes from app.js to main.js. No behaviour change β all 380 tests pass, coverage 87 %. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
static/app.jswith 12 focused ES modules (state.js,dom.js,api.js,format.js,schedule-matrix.js,athletes.js,config.js,settings.js,feed.js,status.js,tabs.js,main.js)state.js(single exported object) β no circular dependenciesroutes.py::serve_indexgenerates an importmap that covers all local modules, so every module is cache-busted on each releaseapp.jsβmain.js;index.htmlupdated accordinglyModule overview
state.jsdom.js$,toast,setButtonLoading,makeRemoveBtn,initRevealButtonsapi.jsfetchJson,putJsonformat.jsformatRelative,formatTime,formatSportLabelschedule-matrix.jsathletes.jsconfig.jssettings.jsfeed.jsstatus.jstabs.jsmain.jsTest plan
ruff check src testsβ zero lint issuesruff format --check src testsβ zero formatting issuesmypy srcβ zero type errorspytestβ 380 passed, coverage 87 %π€ Generated with Claude Code