fix: use model_dump(mode="json") so datetime fields are JSON-serializable in activity cache#32
Merged
Conversation
…able in activity cache Activity.start_date is a datetime object; the plain model_dump() call kept it as a Python datetime, causing a TypeError when store._write_json_atomic called json.dumps(). Align with the already-correct path in routes.py by passing mode="json", which serialises datetime to ISO strings. Adds a regression test that verifies result.activities is fully JSON-serializable even when start_date is set. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Activity.start_dateis adatetimeobject;model_dump()(Python mode) kept it as-is, causingjson.dumpsinstore._write_json_atomicto raiseTypeError: Object of type datetime is not JSON serializablemodel_dump(mode="json")inengine.py(line 197), identical to the already-correct path inroutes.py(line 378)tests/unit/test_engine_cache.pythat assertsresult.activitiesis fully JSON-serialisable whenstart_dateis setTest plan
pytest tests/unit/test_engine_cache.py— new test greenruff check,ruff format --check,mypy— all clean🤖 Generated with Claude Code