Added vector polar plotting#1
Open
bpwrs wants to merge 2 commits into
Open
Conversation
plot_vecs_model_darn_grid now accepts mlt coordinates
Added function lompe_scan_plot_vecs_polar that plots the flow vectors in an mlt-mlat coordinate system, polar view
Owner
|
Hey, so I literally just saw that this PR existed! I will take a look when I'm back from EGU. |
billetd
self-requested a review
June 16, 2026 18:12
billetd
reviewed
Jun 16, 2026
billetd
left a comment
billetd
left a comment
Owner
There was a problem hiding this comment.
Mostly looks good, but can't test currently due to Apex and time objects not being passed in. Take a look as see what you think.
| else: | ||
| print('Allready processed: ' + save_path) | ||
|
|
||
| def lompe_scan_plot_vecs_polar(lompe, path, boundary=True save=True): |
Owner
There was a problem hiding this comment.
Suggested change
| def lompe_scan_plot_vecs_polar(lompe, path, boundary=True save=True): | |
| def lompe_scan_plot_vecs_polar(lompe, path, boundary=True, save=True): |
| plot_vecs_model_darn_grid(lompe, ax, apex=apex, time=scan_time, coord=coord) | ||
|
|
||
| # Boundary box | ||
| if boundary=True: |
Owner
There was a problem hiding this comment.
Suggested change
| if boundary=True: | |
| if boundary == True: |
| if boundary=True: | ||
| plot_boundary_box(lompe, ax, apex, scan_time) | ||
|
|
||
| if save is True: |
Owner
There was a problem hiding this comment.
Suggested change
| if save is True: | |
| if save == True: |
| elif coord == 'mlt': | ||
| u_src_crs = v_emag | ||
| v_src_crs = v_nmag | ||
|
|
Owner
There was a problem hiding this comment.
Suggested change
| magnitude = np.sqrt(v_emag ** 2 + v_nmag ** 2) | |
| magn_src_crs = np.sqrt(u_src_crs ** 2 + v_src_crs ** 2) |
These got accidentally removed
| # magnitude_thick, norm=colours_norm, scale=2000, scale_units='inches', width=0.002, | ||
| # headwidth=3, transform=ccrs.PlateCarree(), angles='xy', cmap='viridis', zorder=3) | ||
| elif coord == 'mlt': | ||
| mlts = apex.mlon2mlt(mlons, time) |
Owner
There was a problem hiding this comment.
The apex and time objects don't get passed into this function. There will need to be some higher level logic in plot_main.py to handle this, or have them brought in as optional variables so it doesn't disturb the code that doesn't require mag conversion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated plot_main.py to add the function lompe_scan_plot_vecs_polar that plots the vectors on the same polar plot as the potential plots, as well as added the ability for plot_vecs_model_darn_grid to accept 'mlt' as a coordinated and than plots on the mlt-mlat poolar plots. Had to adjust the magnitude, angles, and arrow scaling so everything looks right, but the colorbar placement is still wonky on the polar plots, I'll submit another pull request when I get that sorted!