Skip to content

Code cleanup - #60

Open
Misiu wants to merge 9 commits into
billbogaiv:masterfrom
Misiu:master
Open

Code cleanup#60
Misiu wants to merge 9 commits into
billbogaiv:masterfrom
Misiu:master

Conversation

@Misiu

@Misiu Misiu commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

some cleanup that was suggested by Resharper.

Things to consider (probably in the next PR).

Should I replace

var hasBindingAttribute = parameterModel.Attributes
    .Any(x => typeof(IBindingSourceMetadata).IsAssignableFrom(x.GetType()));

with

var hasBindingAttribute = parameterModel.Attributes
    .Any(x => x is IBindingSourceMetadata);

and other similar places?
Also, VS2022 is suggesting many improvements, especially with LINQ.
It would be easier to do such fixes if we had some tests.
But maybe we can figure something out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant