fix: Corrige assertion gtk_box_remove ao fechar janela/aba#1
Open
xathay wants to merge 1 commit into
Open
Conversation
content_view é adicionado ao content_box em create_and_bind_new_content_view(), mas nautilus_window_slot_dispose() remove do vbox (container errado). Isso dispara em todo fechamento de janela/aba: gtk_box_remove: assertion 'gtk_widget_get_parent (child) == (GtkWidget *)box' failed A correção altera o container de remoção de self->vbox para self->content_box, correspondendo ao container onde content_view foi realmente adicionado. Testado no BigCommunity GNOME (GNOME Shell 49.4) - assertion não ocorre mais.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumo
Corrige GTK assertion failure que ocorre toda vez que uma janela ou aba do Nautilus é fechada:
Este bug contribui para instabilidade do Nautilus — em casos extremos, o processo deixa de responder a ativações via DBus, fazendo com que cliques na Dock não abram novas janelas.
Causa raiz
No
src/nautilus-window-slot.cdo fork, a introdução docontent_boxcomo container intermediário para acomodar o terminal embutido criou uma inconsistência:content_viewcreate_and_bind_new_content_view()self->content_boxcontent_viewnautilus_window_slot_dispose()self->vbox(ERRADO)No upstream,
content_boxnão existe —content_viewé adicionado e removido dovboxde forma consistente. Quando o fork introduziu ocontent_box, atualizou oappendmas não atualizou oremovenodispose().Fix
Uma linha no
prepare()do PKGBUILD viased:Validação
gtk_box_removeTest plan
makepkg -se instalar compacman -Ujournalctl --user -n 50 | grep gtk_box_removetalesam/nautilus)