Skip to content

feat: add refresh-message-position option#72

Open
KasperAndersson wants to merge 1 commit into
bibipkins:mainfrom
KasperAndersson:feat/refresh-message-position
Open

feat: add refresh-message-position option#72
KasperAndersson wants to merge 1 commit into
bibipkins:mainfrom
KasperAndersson:feat/refresh-message-position

Conversation

@KasperAndersson

Copy link
Copy Markdown

#71

This pull request introduces a new feature that allows users to refresh the position of an existing comment in a pull request, ensuring it appears as the most recent comment. This is accomplished by adding a new boolean input parameter, refresh-message-position, throughout the codebase and updating the comment publishing logic accordingly.

New input parameter support:

  • Added refresh-message-position as an optional boolean input in action.yml, with documentation in README.md explaining its purpose and default value. [1] [2]
  • Updated the IActionInputs interface and input handling utilities to include the new refreshMessagePosition parameter, ensuring it is available throughout the application. [1] [2] [3]

Comment publishing logic:

  • Modified the publishComment function in comments.ts to support refreshing the comment's position by deleting and recreating the comment if refreshMessagePosition is true, instead of just updating it. [1] [2]
  • Updated all invocations of publishComment in main.ts to pass the new refreshMessagePosition parameter, so the feature is applied consistently. [1] [2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant