Skip to content

Fix TypeScript types and dependencies #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bhrionn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix TypeScript types and dependencies #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web-app/src/components/files/__tests__/FileUploadForm.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ describe('FileUploadForm', () => {
mockUploadService.validateFile.mockReturnValue(validationResult);

mockUploadService.uploadFile.mockImplementation(
async (file: File, metadata: any, observer?: ProgressObserver) => {
async (_file: File, _metadata: any, observer?: ProgressObserver) => {
// Simulate progress updates
if (observer?.next) {
observer.next({ loaded: 50, total: 100, percentage: 50 });
Expand Down
9 changes: 3 additions & 6 deletions web-app/src/pages/__tests__/LoginPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,11 @@

import { render, screen, waitFor } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { BrowserRouter, MemoryRouter } from 'react-router-dom';
import { MemoryRouter } from 'react-router-dom';
import { LoginPage } from '../LoginPage';
import { AuthProvider } from '../../contexts/AuthContext';
import { ToastProvider } from '../../components/common/Toast';
import type { IAuthService } from '../../services/IAuthService';
import type { User } from '../../types/auth';

// Test wrapper component
const TestWrapper: React.FC<{
Expand Down Expand Up @@ -232,9 +231,8 @@ describe('LoginPage', () => {
});

it('disables buttons during login attempt', async () => {
let resolveLogin: () => void;
const loginPromise = new Promise<void>((resolve) => {
resolveLogin = resolve;
const loginPromise = new Promise<void>((_resolve) => {
// Login promise never resolves to simulate pending state
});
mockAuthService.login.mockReturnValue(loginPromise);

Expand All @@ -249,7 +247,6 @@ describe('LoginPage', () => {
});

const googleButton = screen.getByTestId('login-google-button');
const microsoftButton = screen.getByTestId('login-microsoft-button');

// Click button to start login
userEvent.click(googleButton);
Expand Down
20 changes: 15 additions & 5 deletions web-app/src/services/__tests__/ErrorLoggingService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,14 @@ describe('ErrorLoggingService', () => {

beforeEach(() => {
mockApiClient = {
uploadFile: jest.fn(),
getUserFiles: jest.fn(),
getFileMetadata: jest.fn(),
getPresignedUrl: jest.fn(),
post: jest.fn().mockResolvedValue({ data: {} }),
get: jest.fn(),
put: jest.fn(),
delete: jest.fn(),
setAuthToken: jest.fn(),
clearAuthToken: jest.fn(),
} as jest.Mocked<IApiClient>;

errorLoggingService = new ErrorLoggingService(mockApiClient);
Expand Down Expand Up @@ -141,8 +143,13 @@ describe('ErrorLoggingService', () => {
});

it('should sanitize stack trace in production', async () => {
const originalEnv = process.env.NODE_ENV;
process.env.NODE_ENV = 'production';
// Mock NODE_ENV by temporarily replacing it
const originalNodeEnv = Object.getOwnPropertyDescriptor(process.env, 'NODE_ENV');
Object.defineProperty(process.env, 'NODE_ENV', {
value: 'production',
writable: true,
configurable: true,
});

const error = new Error('Test error');
error.stack = Array(20).fill('at Test (file.ts:1:1)').join('\n');
Expand All @@ -153,7 +160,10 @@ describe('ErrorLoggingService', () => {
const stackLines = logEntry.stack?.split('\n').length || 0;
expect(stackLines).toBeLessThanOrEqual(10);

process.env.NODE_ENV = originalEnv;
// Restore original NODE_ENV
if (originalNodeEnv) {
Object.defineProperty(process.env, 'NODE_ENV', originalNodeEnv);

Copilot AI Nov 18, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The restoration logic for NODE_ENV is incomplete. If originalNodeEnv is undefined, the property should be deleted instead of left in the modified state. Add an else clause to delete the property when originalNodeEnv is undefined.

Suggested change
Object.defineProperty(process.env, 'NODE_ENV', originalNodeEnv);
Object.defineProperty(process.env, 'NODE_ENV', originalNodeEnv);
} else {
delete process.env.NODE_ENV;

Copilot uses AI. Check for mistakes.
}
});
});

Expand Down
7 changes: 6 additions & 1 deletion web-app/src/services/__tests__/NotificationService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,13 @@ describe('NotificationService', () => {
beforeEach(() => {
mockToastContext = {
showToast: jest.fn(),
showSuccess: jest.fn(),
showError: jest.fn(),
showWarning: jest.fn(),
showInfo: jest.fn(),
hideToast: jest.fn(),
hideAllToasts: jest.fn(),
};
} as jest.Mocked<IToastContext>;

notificationService = new NotificationService(mockToastContext);
});
Expand Down
1 change: 0 additions & 1 deletion web-app/src/utils/__tests__/accessibility.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

import {
announceToScreenReader,
trapFocus,
getFocusableElements,
createFocusManager,
generateAriaId,
Expand Down
Loading