ideogram: use _scaled_mm for fp8 matmul, sorry non-Ada-or-newer owners#2740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for efficient FP8 matrix multiplication using scaled matmul on compatible CUDA devices in the
ideogramquantized loading helpers. The most significant change is the addition of a custom autograd function to accelerate FP8 linear layers when supported hardware and software conditions are met.FP8 Scaled Matmul Support:
_scaled_mm_supportedto check if the current environment and tensor are suitable for using the optimized FP8 scaled matrix multiplication, with an environment variable override for manual control._Fp8LinearScaledMmcustom autograd function to perform forward and backward passes usingtorch._scaled_mmfor FP8 inputs, including dynamic input scaling and proper handling of gradients.forwardmethod in the quantized linear class to use the new scaled FP8 path when supported, falling back to the previous dequantized path otherwise.General Improvements:
osmodule to support environment variable checks.FP8_INPUT_DTYPEfor clarity and consistency in FP8 input handling.