Skip to content

deps: bump node 20 → 26#6836

Open
jaskfla wants to merge 10 commits into
devfrom
bump-node
Open

deps: bump node 20 → 26#6836
jaskfla wants to merge 10 commits into
devfrom
bump-node

Conversation

@jaskfla

@jaskfla jaskfla commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Issue #:

Changes:

  • Example

Screenshots:


🦸 Review Hero

  • Run Review Hero
  • Auto-fix review suggestions
  • Auto-fix CI failures
  • Save suppressions

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 4e2a9fd. Configure here.

fetch_latest_code

# In case .nvmrc has changed in current branch (normally redundant)
nvm install --default

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cron PATH before Node upgrade

Medium Severity

On production startup, schedule_preaggregation_job runs before fetch_latest_code and nvm install --default, so the crontab line embeds a PATH from the previous Node default. After this PR’s .nvmrc bump, deploy builds use Node 26 while the daily preaggregation job can still invoke Node 20 (or miss yarn/node on PATH).

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 4e2a9fd. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant