tweak(database): make project.entity_hierarchy_id non-nullable

[jaskfla]

Every project has one set; and we already enforce this at application level.

This makes various if (!hierarchyId) throw new Error() assertions redundant.

[gemini-code-assist]

Summary of Changes

Hello @jaskfla, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances data integrity by enforcing the non-nullable constraint for project.entity_hierarchy_id directly within the database schema. This change not only strengthens the data model but also streamlines application code by eliminating the need for repetitive null checks, ensuring consistency between the database and the application's type definitions.

Highlights

• Database Schema Update: The entity_hierarchy_id column in the public.project table has been updated to be non-nullable, aligning the database schema with existing application-level enforcement.
• Type Definition Alignment: TypeScript interfaces Project and ProjectCreate were modified to reflect that entity_hierarchy_id is a required string, while ProjectUpdate was adjusted to allow entity_hierarchy_id to be an optional string (but not null).
• Code Simplification: This change enables the removal of redundant if (!hierarchyId) throw new Error() assertions in the application code, leading to cleaner and more robust logic.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• packages/database/src/migrations/20260219235604-MakeProjectEntityHierarchyIdNonnullable-modifies-schema.js
  • Added a new migration file to modify the project table.
  • Implemented an up function to set the entity_hierarchy_id column as NOT NULL.
  • Implemented a down function to revert the entity_hierarchy_id column to be nullable.
• packages/types/src/types/models.ts
  • Updated the Project interface to mark entity_hierarchy_id as a required string.
  • Updated the ProjectCreate interface to mark entity_hierarchy_id as a required string.
  • Updated the ProjectUpdate interface to mark entity_hierarchy_id as an optional string (removing null from its type).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request makes the entity_hierarchy_id on the project table non-nullable, which is a good step for improving data integrity as it's already enforced at the application level. The changes include a database migration to apply the NOT NULL constraint and updates to the TypeScript types to reflect this change. The implementation is correct. I've added one comment regarding the process of updating generated files, suggesting to use the generator script instead of manual edits for better maintainability.