deps: RN-1761: bump moment 2.24 → 2.30#6478
Conversation
Summary of ChangesHello @jaskfla, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on crucial dependency updates for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly bumps the moment and moment-timezone dependencies across multiple packages to address security vulnerabilities. This is a necessary and well-executed change. I've added one suggestion for future consideration regarding the long-term maintenance of date/time handling in the project.
# Conflicts: # packages/meditrak-app/package.json # packages/ui-components/package.json # yarn.lock
# Conflicts: # packages/database/package.json # yarn.lock
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5922651. Configure here.
| "lodash.keyby": "^4.6.0", | ||
| "lodash.orderby": "^4.6.0", | ||
| "moment": "^2.24.0", | ||
| "moment": "^2.30.1", |
There was a problem hiding this comment.
Missed moment-timezone bump in database package
Low Severity
The moment-timezone dependency in packages/database/package.json remains at ^0.5.45 while every other package in the monorepo (central-server, meditrak-app-server, tsutils, utils, web-config-server) was bumped to ^0.6.0. This appears to be an oversight given the PR's stated intent to bump moment-timezone alongside moment.
Reviewed by Cursor Bugbot for commit 5922651. Configure here.


RN-1761
Fixes:
Bumping moment-timezone is technically unrelated, but it’s a small update, effectively just narrowing some TypeScript types. Still builds.
Note
Upgrades date libs by raising moment to ^2.30.1 across packages and moment-timezone to ^0.6.0 where used.
momentto^2.30.1across multiple packages (admin-panel,central-server,data-api,data-broker,data-lake-api,database,e2e,lesmis,meditrak-app,report-server,tupaia-web,ui-chart-components,ui-components,ui-map-components).moment-timezoneto^0.6.0in packages using it (central-server,meditrak-app-server,tsutils,utils,web-config-server).Written by Cursor Bugbot for commit 46be079. This will update automatically on new commits. Configure here.