Skip to content

deps: RN-1761: bump moment 2.24 → 2.30#6478

Open
jaskfla wants to merge 6 commits into
devfrom
rn-1761-moment
Open

deps: RN-1761: bump moment 2.24 → 2.30#6478
jaskfla wants to merge 6 commits into
devfrom
rn-1761-moment

Conversation

@jaskfla

@jaskfla jaskfla commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

RN-1761

Fixes:

Bumping moment-timezone is technically unrelated, but it’s a small update, effectively just narrowing some TypeScript types. Still builds.


Note

Upgrades date libs by raising moment to ^2.30.1 across packages and moment-timezone to ^0.6.0 where used.

  • Dependencies:
    • Upgrade moment to ^2.30.1 across multiple packages (admin-panel, central-server, data-api, data-broker, data-lake-api, database, e2e, lesmis, meditrak-app, report-server, tupaia-web, ui-chart-components, ui-components, ui-map-components).
    • Upgrade moment-timezone to ^0.6.0 in packages using it (central-server, meditrak-app-server, tsutils, utils, web-config-server).

Written by Cursor Bugbot for commit 46be079. This will update automatically on new commits. Configure here.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @jaskfla, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on crucial dependency updates for the moment and moment-timezone libraries across various packages. The primary goal is to mitigate security vulnerabilities associated with the moment library, as flagged by Dependabot. Additionally, the moment-timezone update introduces minor improvements, specifically refining TypeScript type definitions, all while ensuring the project continues to build without issues.

Highlights

  • Dependency Update: moment: The moment library has been updated from version 2.24.0 to 2.30.1 across multiple packages in the monorepo.
  • Dependency Update: moment-timezone: The moment-timezone library has been updated from version 0.5.45 to 0.6.0 in several key packages, primarily to narrow TypeScript types.
  • Security Fixes: This update addresses two identified Dependabot security vulnerabilities related to the moment library.
  • Build Status: The changes, including the moment-timezone update, have been confirmed to build successfully.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly bumps the moment and moment-timezone dependencies across multiple packages to address security vulnerabilities. This is a necessary and well-executed change. I've added one suggestion for future consideration regarding the long-term maintenance of date/time handling in the project.

Comment thread packages/utils/package.json
@jaskfla jaskfla added the dependencies Pull requests that update a dependency file label Sep 30, 2025
# Conflicts:
#	packages/meditrak-app/package.json
#	packages/ui-components/package.json
#	yarn.lock
# Conflicts:
#	packages/database/package.json
#	yarn.lock

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5922651. Configure here.

"lodash.keyby": "^4.6.0",
"lodash.orderby": "^4.6.0",
"moment": "^2.24.0",
"moment": "^2.30.1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed moment-timezone bump in database package

Low Severity

The moment-timezone dependency in packages/database/package.json remains at ^0.5.45 while every other package in the monorepo (central-server, meditrak-app-server, tsutils, utils, web-config-server) was bumped to ^0.6.0. This appears to be an oversight given the PR's stated intent to bump moment-timezone alongside moment.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 5922651. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant