fix: RN-1727: update endpoint for Nominatim search

[jaskfla]

Issue #:

Changes:

• Example

---

Screenshots:

[gemini-code-assist]

Summary of Changes

Hello @jaskfla, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where GeoJSON search queries were not properly URI-encoded, potentially leading to incorrect search results or errors when dealing with special characters. I've refactored the search query construction to ensure proper encoding and improved diacritic handling.

Highlights

• Improved Diacritic Handling: Replaced a custom getLatin1 function with a more robust removeDiacritics function that uses Unicode normalization to handle a wider range of diacritics.
• Robust URL Construction: Switched from manual string concatenation to using the URL and URLSearchParams Web APIs for building the Nominatim search URL. This ensures proper URI encoding of query parameters.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively fixes a URI encoding bug for the GeoJSON search by correctly using the URL API to build the request. This prevents errors with special characters in search terms. The change also introduces a more robust method for removing diacritics from the search query, replacing an incomplete manual implementation. The code quality is high, and these changes significantly improve the feature's reliability.

[edmofro]

bugbot run

[chris-bes]

LGTM!

[jaskfla]

@chris-bes Don’t think we’ll be getting to the “real” fix for RN-1727 any time soon

Added some unit tests this morning for the refactored removeDiacritics. The only other code changes were for:

• changing the Nominatim endpoint to use HTTPS instead of HTTP; and
• using a URL instead of string templating

How do we feel about merging this and letting regression testing cover it? cc @avaek

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}