Allow manual volume entry for bottles widget#151
Open
nnpvaan wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the sample type container controller so bottle volume is only auto-calculated and forced read-only when the selected bottles setup is configured for automatic volume calculation. It also rebuilds the bundled frontend assets and updates the static resource reference.
Linked issue: https://github.com/beyondessential/bes.tuvalu.lims/issues/4
Current behavior
When the
Bottleswidget is shown in the add form, the mainVolumefield is forced to read-only and bottle volume recalculation still runs on bottle container/weight changes, even for setups where bottle volume should be entered manually.Desired behavior
When the
Bottleswidget is shown in the add form, the mainVolumefield is only read-only if bottle volume is auto-calculated. For manual bottle-volume setups, theVolumefield stays editable and automatic recalculation is skipped.--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.