Skip to content

Update dom wip#37

Merged
beykyle merged 11 commits into
mainfrom
update_dom_wip
May 28, 2026
Merged

Update dom wip#37
beykyle merged 11 commits into
mainfrom
update_dom_wip

Conversation

@beykyle
Copy link
Copy Markdown
Owner

@beykyle beykyle commented May 28, 2026

  • unify comments and docstrings
  • flesh out testing
  • add CI
  • more sennsible defaults for jitr wrappers
  • decrease exfor_tools reliance (allow for flexible construction of reaction related Observation-derived objects)

@beykyle
Copy link
Copy Markdown
Owner Author

beykyle commented May 28, 2026

@copilot review this PR

Copy link
Copy Markdown
Contributor

Copilot AI commented May 28, 2026

@copilot review this PR

Reviewed and found one blocking bug in scalar-like systematic error parsing in set_up_observation; fixed in d7c09f4 with regression tests for scalar-like offset/normalization inputs. Validation run: python -m unittest discover ./test, isort --check-only src test, black --check src test, ruff check src test, and python -m build all pass.

@beykyle beykyle merged commit 6de9e60 into main May 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants