Initial harper integration for the book#2467
Draft
fallible-algebra wants to merge 2 commits into
Draft
Conversation
Contributor
Author
|
(Note that this is expected to fail right now, because we've not fixed the errors in the book or properly populated the dictionary) |
fallible-algebra
added
A-Book
A-Build-System
C-Feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #2463, but only keep it to the book (for now).
The
harper-clitool is still in its infancy, but the underlying harper tooling it relies on is pretty solid. I couldn't getcargo-binstallworking with this, so it uses another action to fetch the binary instead. Open to opinions on all of this.Only doing this for the book for now, we should be careful about what files / directories we expand it to (if we choose to).