Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ agents.md
.agents

/smoke
/Elitea-testing-webQAPreExecuted
/Elitea-testing-WebQAPreExecuted
.env

# Node / Playwright
Expand Down
8 changes: 5 additions & 3 deletions test-specs/artifacts/l3_upload-11-images-reject_TC-043.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ No new tracker issue filed. This is a genuine pass matching the case's own accep
| Step 14: verify only 10 files from batch appear (01–10), not 11 | exactly 10, 11 absent | step 10 | step 10 (pagination footer "1 - 10 of 10" + row-name check) | asserted |
| Expected Final State — Ideal (Behavior A) | rejected, nothing sent | — | — | **not applicable** — live product implements Behavior B, not A (case explicitly allows either) |
| Expected Final State — Fallback (Behavior B) | truncate to 10, 11th rejected silently/with warning, 10 files uploaded | steps 5–10 | steps 5–10 | asserted — matches almost exactly; the "warning" takes the form of a persistent disabled/ambient composer state, not a transient toast |
| Teardown: "if uploaded (B), delete files 01–10 from artifacts" | cleanup performed | — | | **out-of-scope by project precedent** — see § Cleanup; this batch's additive, non-destructive uploads follow the same no-cleanup convention already established for TC-001/TC-002/TC-032/TC-036/TC-038 |
| Teardown: "if uploaded (B), delete files 01–10 from artifacts" | cleanup performed | — | outer `finally` teardown, `deleteArtifactAndVerify()` | **asserted** *(amended post-merge review, 2026-07-06 — see § Cleanup; originally deferred as out-of-scope by the TC-001/TC-002/TC-032/TC-036/TC-038 no-cleanup precedent, but that precedent doesn't transfer to a real 10-file storage footprint left on every run with no expiry — automation now deletes this run's own uuid folder)* |
| Teardown: "if not uploaded (A), no cleanup needed" | n/a | — | — | **not applicable** — Behavior B occurred, files were uploaded; see prior row for the applicable teardown guidance |

### Axis 2 — Analyst additions
Expand All @@ -129,9 +129,11 @@ No new tracker issue filed. This is a genuine pass matching the case's own accep
- Explicit no-toast check (`[role=alert]`, `[role=status]`, toast/snackbar-class selectors, sampled immediately post-truncation) — *added: rules out a transient warning this AFS's snapshots might otherwise have missed; none found. Documented as a deliberate absence-check, not an omission.*

## Cleanup
The sent 10-image message is **not destructive** — same category as TC-001/TC-002's "chat messages persist, no teardown" precedent, and consistent with TC-032/TC-036/TC-038's cleanup decisions elsewhere in this module. Recommended: **no automated cleanup**, especially given other sibling analysts (TC-039, TC-042) are concurrently mutating the same shared `${TEST_USER}` account this session — an extra delete-after-test step adds one more concurrent mutation for no correctness benefit.
The sent 10-image message is **not destructive** — same category as TC-001/TC-002's "chat messages persist, no teardown" precedent, and consistent with TC-032/TC-036/TC-038's cleanup decisions elsewhere in this module. Originally recommended **no automated cleanup**, especially given other sibling analysts (TC-039, TC-042) are concurrently mutating the same shared `${TEST_USER}` account this session — an extra delete-after-test step adds one more concurrent mutation for no correctness benefit.

If strict account hygiene is later required:
**Amendment (post-merge review, 2026-07-06, implementer): this recommendation is superseded — automation now deletes the 10 retained files in a `finally` teardown, matching TC-042's pattern.** The "no cleanup" reasoning above was sound for a bare chat message (TC-001/002/032/036/038's category: additive, non-destructive, no *storage* cost beyond the message row itself) but doesn't transfer to this case's own Behavior-B path: a real, successful 10-image upload leaves 10 files sitting in the shared, finite Artifacts bucket on every automated run (CI + local + the orchestrator's repeat independent-gate runs), with no compensating expiry — a permanent per-run leak, not a merely-additive record. The concurrency concern that motivated skipping cleanup still doesn't apply: this test's delete only ever touches its OWN uuid folder (captured from its own upload responses), never a sibling's, so it carries no more concurrent-mutation risk than TC-039/TC-042's own teardowns already accept for the identical reason. If a future case in this module ever needs a genuinely non-destructive, no-storage-footprint variant of this scenario, prefer read-only assertions against already-uploaded fixtures over reintroducing an uncleaned batch upload.

If strict account hygiene is later required beyond the above:
1. Delete the conversation named `Test batch upload of 11 images - expect rejection` (conversation id captured at step 7).
2. Delete the artifact folder `attachments/{uuid}/` (from step 7's response) via the Artifacts UI's row-level delete action.

Expand Down
Loading
Loading