Support up to Cabal 3.16#13
Merged
Merged
Conversation
Contributor
Author
|
It looks like the CI needs updating. Can you take a look at it? |
Vekhir
force-pushed
the
support-up-to-9.14
branch
from
ac949c9 to
c39e899
Compare
Contributor
Author
|
@berberman I've updated the CI and the tests are now passing. Is anything else holding up this PR for |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@berberman This PR adds support for Cabal up to 3.16.
Cabal 3.14 uses
SymbolicPathinstead ofFilePath. The difference is thatSymbolicPathcan only be used to manipulate the path, without doing file operations; to get the underlyingFilePath,getSymbolicPathis used.The change is significant enough that it becomes easier to just duplicate the affected functions.
Cabal 3.12 changes the return value for
findPackageDescto return an Exception instead of a String. The use ofshowjust turns it into a string again. This is backwards-compatible.Cabal 3.16 works out-of-the-box. It just needs a dependency bump to be supported.
Verified on Arch Linux with GHC 9.6.6, 9.12.4, and 9.14.1. The CI also checks 9.8.4 and 9.10.3.
Fixes #11